fix(init): materialize sentry auth token placeholders#1114
Draft
betegon wants to merge 1 commit into
Draft
Conversation
Contributor
|
Contributor
Codecov Results 📊✅ Patch coverage is 92.86%. Project has 5054 uncovered lines. Files with missing lines (1)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 81.24% 81.23% -0.01%
==========================================
Files 388 388 —
Lines 26910 26920 +10
Branches 17481 17491 +10
==========================================
+ Hits 21861 21866 +5
- Misses 5049 5054 +5
- Partials 1822 1827 +5Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Init can now safely apply Sentry auth-token placeholders in local config files. The server can emit
___ORG_AUTH_TOKEN___, while the CLI replaces it locally for.sentryclirc,sentry.properties, and env files duringapply-patchset.Changes
The replacement runs after both created file content and modify edits are resolved, so deterministic Cocoa and React Native config can use the same placeholder path. Existing env-file empty-token replacement still works as before.
Test Plan
pnpm exec biome check src/lib/init/tools/apply-patchset.ts test/lib/init/tools/filesystem-tools.test.tspnpm vitest run test/lib/init/tools/filesystem-tools.test.ts